This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
rename telemetry key names at the service level #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranweiler
approved these changes
Apr 5, 2021
| @@ -222,8 +222,8 @@ def save_proxy_config(self) -> None: | |||
| ), | |||
| forwards=forwards, | |||
| region=self.region, | |||
| instrumentation_key=os.environ.get("APPINSIGHTS_INSTRUMENTATIONKEY"), | |||
| telemetry_key=os.environ.get("ONEFUZZ_TELEMETRY"), | |||
| instance_telemetry_key=os.environ.get("APPINSIGHTS_INSTRUMENTATIONKEY"), | |||
There was a problem hiding this comment.
Right now, whenever we grab these key from the environment, we need to remember and preserve the mapping instance <-> instrumentation, microsoft <-> telemetry.
I suggest renaming the env vars elsewhere, but in the meantime, maybe we should define wrappers to os.environ.get, e.g.:
def get_microsoft_telemetry_key() -> str:
return os.environ.get("ONEFUZZ_TELEMETRY")We could also just exports constants.
Merged
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #766, the telemetry keys were renamed to reduce confusion. However, this broke the telemetry keys within the agent due to a known issue using flattened json with aliases (See serde-rs/serde#1976).
This PR removes the aliases and fixes the agent level telemetry & logging.